Repository navigation
fix(search): local fuzzy document search returns non-document results - #2242
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughAdded a Changes
Possibly related PRs
🚥 Pre-merge checks | ✅ 1 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@js/app/packages/app/component/next-soup/soup-view/soup-view.tsx`:
- Around line 655-673: When restoring a stale persisted state that has
activeTab, guard against applyTabPreset silently failing: change the logic
around isStale && isListViewID(contentId) && initialPersistedState.activeTab to
call applyTabPreset(contentId, initialPersistedState.activeTab) and check its
success (have applyTabPreset return boolean or detect no-op); if it fails, run
the fallback batch that initializes soup.filters (soup.filters.set),
setQueryFilters and setActiveTab using the same values as the existing else
branch (use props.initialClientFilters when isStale, otherwise
initialPersistedState.filters, and queryFilters/activeTab from
initialPersistedState) so filters are never left uninitialized.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 94a78bd2-b524-476c-ba51-acbd17012eb3
📒 Files selected for processing (3)
js/app/packages/app/component/app-sidebar/soup-filter-presets.tsjs/app/packages/app/component/next-soup/filters/configs.tsjs/app/packages/app/component/next-soup/soup-view/soup-view.tsx
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@js/app/packages/app/component/next-soup/soup-view/soup-view-tabs.tsx`:
- Around line 109-112: The function applyTabPreset reads VIEW_TAB_PRESETS[view]
then accesses config.tabs without checking config exists; add a guard to ensure
config is defined before accessing config.tabs (e.g., if (!config) return false)
so non-tabbed ListView values won't cause a runtime crash; update applyTabPreset
to check VIEW_TAB_PRESETS[view] (the local variable config) prior to using
config.tabs and only proceed to resolve resolver when config is present.
🪄 Autofix (Beta)
✅ Autofix completed
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: abaeae68-2308-473b-905e-cced38619281
⛔ Files ignored due to path filters (1)
js/app/bun.lockis excluded by!**/*.lock,!**/bun.lock
📒 Files selected for processing (3)
js/app/package.jsonjs/app/packages/app/component/next-soup/soup-view/soup-view-tabs.tsxjs/app/packages/app/component/next-soup/soup-view/soup-view.tsx
|
Note Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it. Fixes Applied SuccessfullyFixed 1 file(s) based on 1 unresolved review comment. Files modified:
Commit: The changes have been pushed to the Time taken: |
Fixed 1 file(s) based on 1 unresolved review comment. Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
No description provided.